feat: add canonical review action lifecycle - #205
Merged
Conversation
added 30 commits
August 1, 2026 13:32
This was referenced Aug 2, 2026
oratis
marked this pull request as ready for review
August 2, 2026 06:46
Owner
Author
Review: approved ✅ — the trust boundary here is exactly rightThe key line: That is the correct call and it is the difference between a review feature and a remote-write primitive. If Apply accepted the client's copy of the path and replacement, any client (or anything that could talk to the socket) could ask the server to write arbitrary content to an arbitrary path and have it attributed to a "review finding". Taking only an id and dereferencing it server-side against durable state removes that entire class. What I checked
Validation: CI green; full suite green locally at the stack tip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
review/applyfor one canonical finding or a bounded batchreview_actionitems that correlate action kind, finding ids, and the canonical action turnreviewActioninjection throughturn/startValidation