ci: require warning-free quality gates - #210
Conversation
Review: approved ✅ — stack capstone+10/−5. Removes the last repository lint warning and sets root lint to fail on any future one. On On the honesty of the final item: keeping real tag publication, Apple credentials, notarization, and updater signing explicitly outside automatic code mutation is the correct boundary. Those are operator actions with irreversible consequences, and a stack that automated them would be a stack that could publish on its own. Good that it stops short. Closing note on #180–#210 as a whole. Reviewed and merged all 31 in dependency order. The through-line is consistent and the sequencing is disciplined: the gate bypass in #181 was the actual severe bug (an omitted Verified locally at the stack tip before merging: typecheck, Two things I flagged along the way that are worth carrying forward rather than losing in the merge: the ~6.7 MB → ~115 MB desktop size increase from the Node sidecar (#187) belongs in user-facing release notes, and the plugin capability API is not an OS boundary (#200/#209) — third-party plugins remain trusted code until an OS sandbox lands. |
…fix (#211) Supersedes #170 and #171, which each bump only half the pair and cannot merge independently — react@19 with react-dom@18 (or vice versa) is a broken tree. React 19's @types/react removes the global `JSX` namespace; it now lives under `React.JSX` and is re-exported as a named type from 'react'. 38 `JSX.Element` references across 25 desktop files were resolving against the old global and fail with TS2503 under the new types. Each file now imports the type explicitly, merged into its existing 'react' import where one exists so no duplicate-import lint warning is introduced (root lint is --max-warnings=0 as of #210). Verified with a forced rebuild (`tsc -b --force`) rather than an incremental one — `tsc -b` reuses .tsbuildinfo and silently skips the desktop project, which masks exactly this class of failure. - tsc -b --force, lint (--max-warnings=0), format:check: clean - 1033 tests across 8 packages: pass - pnpm build: pass - desktop Playwright protocol journey (4 tests): pass Co-authored-by: t <t@t> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
…ajors (#215) Covers the 31-PR Codex alignment stack (#180-#210) plus the dependency work (#211-#214, #155, #177-#179). Leads with the security section because that is what this release is: the central tool gate could be skipped entirely when `mode` was omitted (#181), and the desktop renderer held provider credentials (#192). Upgrade notes call out the two things a user could otherwise be surprised by — the ~6.7 MB → ~115 MB desktop size increase from the Node sidecar, and that the plugin capability RPC is not an OS boundary. Co-authored-by: t <t@t> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Summary
Validation
Stacked on #209.