Skip to content

⚡ Bolt: Remove unnecessary String clone in scheduler hot path - #92

Merged
ovasylenko merged 4 commits into
mainfrom
bolt/fix-unnecessary-handler-clone-14677780503107139046
Jul 15, 2026
Merged

⚡ Bolt: Remove unnecessary String clone in scheduler hot path#92
ovasylenko merged 4 commits into
mainfrom
bolt/fix-unnecessary-handler-clone-14677780503107139046

Conversation

@ovasylenko

Copy link
Copy Markdown
Contributor

💡 What: Removed a .clone() call on step.handler inside the scheduler.rs loop when dispatching to activepieces.
🎯 Why: handle_ap expects a &str. The code was cloning the String into a new handler_name local variable simply to pass its reference, which creates an entirely unnecessary heap allocation on every evaluation of this hook within the scheduler tick.
📊 Impact: Eliminates a redundant String heap allocation on the hot path for activepieces step evaluation.
🔬 Measurement: Verify via cargo test -p orch8-engine --lib scheduler::tests, ensuring all test cases pass without regressions.


PR created automatically by Jules for task 14677780503107139046 started by @ovasylenko

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules Bot and others added 4 commits July 15, 2026 15:47
Co-authored-by: ovasylenko <3797513+ovasylenko@users.noreply.github.com>
Co-authored-by: ovasylenko <3797513+ovasylenko@users.noreply.github.com>
Co-authored-by: ovasylenko <3797513+ovasylenko@users.noreply.github.com>
Co-authored-by: ovasylenko <3797513+ovasylenko@users.noreply.github.com>
@ovasylenko
ovasylenko force-pushed the bolt/fix-unnecessary-handler-clone-14677780503107139046 branch from 46ecd4c to 851752d Compare July 15, 2026 18:47
@ovasylenko
ovasylenko merged commit bed4877 into main Jul 15, 2026
10 checks passed
@ovasylenko
ovasylenko deleted the bolt/fix-unnecessary-handler-clone-14677780503107139046 branch July 16, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant