⚡ Bolt: Remove unnecessary String clone in scheduler hot path - #92
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: ovasylenko <3797513+ovasylenko@users.noreply.github.com>
Co-authored-by: ovasylenko <3797513+ovasylenko@users.noreply.github.com>
Co-authored-by: ovasylenko <3797513+ovasylenko@users.noreply.github.com>
Co-authored-by: ovasylenko <3797513+ovasylenko@users.noreply.github.com>
46ecd4c to
851752d
Compare
💡 What: Removed a
.clone()call onstep.handlerinside thescheduler.rsloop when dispatching toactivepieces.🎯 Why:
handle_apexpects a&str. The code was cloning theStringinto a newhandler_namelocal variable simply to pass its reference, which creates an entirely unnecessary heap allocation on every evaluation of this hook within the scheduler tick.📊 Impact: Eliminates a redundant
Stringheap allocation on the hot path for activepieces step evaluation.🔬 Measurement: Verify via
cargo test -p orch8-engine --lib scheduler::tests, ensuring all test cases pass without regressions.PR created automatically by Jules for task 14677780503107139046 started by @ovasylenko