fix(session): runtime feedback, canvas lifecycle, SessionCore status audit#281
Closed
beruro wants to merge 5 commits into
Closed
fix(session): runtime feedback, canvas lifecycle, SessionCore status audit#281beruro wants to merge 5 commits into
beruro wants to merge 5 commits into
Conversation
Pre-commit hook ran. Total eslint: 0, total circular: 0
Unify send-feedback UX across composer banners, sidebar status, and queue dispatch toasts. Extract session runtime helpers and session-scoped timeline boundaries; align SessionCore active/installing status. Remove useCanvasPreviewForSession shim and wire useCanvasForTurn at call sites. Pre-commit hook ran. Total eslint: 0, total circular: 0
Pre-commit hook ran. Total eslint: 0, total circular: 0
)" This reverts commit 44c22d6. Pre-commit hook ran. Total eslint: 0, total circular: 0
This was referenced Jul 21, 2026
Collaborator
Author
|
Superseded by the clean, independently reviewable Draft PRs #474, #476, and #477. The remaining historical HUD/queue feedback portion was intentionally not restored because current develop has replaced it with later session-status and queue-FSM architecture. The original branch is retained for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessionRuntimeExecuting,dispatchFailureMessage,sessionSidebarStatusTone,ComposerSessionHudBanners, andqueueDispatchFeedbackhelpers with Vitest coverage.isSessionEngineActiveStatusalignment, installing-state fixes, session-scoped timeline boundary helpers, and adapter/sync updates.useCanvasForTurnmigration—removeuseCanvasPreviewForSessionshim, session-switch clear, tab soft-dismiss, and related canvas preview atom wiring.Test plan
pnpm exec vitest runon new session/boundary helper test files (44 tests)sessions.jsonkeys