fix(chat): restore file pills across message edits - #357
Merged
Conversation
Neonforge98
pushed a commit
that referenced
this pull request
Jul 30, 2026
fix(chat): restore file pills across message edits
Harry19081
self-requested a review
July 30, 2026 08:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PILL_REGEXis global, so calling.test()mutatedlastIndex. Repeated checks of the same message alternated between matching and not matching, which made the second edit entry render rawdisplayName [file:path]text.For file pills without whitespace before the serialized label, the parser also preserved the basename as normal text while creating a pill for the same file.
Verification
vitest run src/engines/ChatPanel/InputArea/utils/__tests__/pillContentParser.test.ts— 16 tests passedtsc --noEmit --pretty false— passedgit diff --check origin/develop...HEAD— passedAudit
srcfor stateful global-RegExp.test()usage;PILL_REGEX.test()was the only matching instance in this problem classapplyParsedContent