Skip to content

refactor(session): scope pending plan approval reads#473

Merged
Harry19081 merged 1 commit into
developfrom
junyu/rebuild-plan-approval-hook
Jul 22, 2026
Merged

refactor(session): scope pending plan approval reads#473
Harry19081 merged 1 commit into
developfrom
junyu/rebuild-plan-approval-hook

Conversation

@beruro

@beruro beruro commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a session-scoped usePendingPlanApproval hook backed by a derived atom family
  • migrate pending-plan read consumers while retaining pendingPlanApprovalsAtom as the single write/source-of-truth path
  • add focused coverage for session isolation and empty-session behavior

Supersedes closed PR #318. This rebuild starts from current develop.

Validation

  • 24 focused Vitest tests passed
  • tsc --noEmit --pretty false
  • ESLint on all 10 changed files
  • git diff --check
  • GitHub Frontend and Rust CI passed

Scope notes

  • preserves the existing rehydrate race protection on develop
  • does not duplicate or replace usePlanApproval
  • does not add a second writable approval atom

@beruro
beruro marked this pull request as ready for review July 21, 2026 13:52
@Harry19081
Harry19081 merged commit 66005b2 into develop Jul 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants