fix(github): support PR session drops and fresh comments - #574
Merged
Conversation
Audit follow-ups for the session-drop and PR-cache work, dual-instance verified on the live app: - insertReferenceText resolves the drop coordinates via posAtCoords and never replaces an active range (collapses to its end); a walk-left retry covers Chromium returning null for points right of a short line (found live: same x resolves once the line grows past it) - inserted references strip ambient marks (unsetAllMarks over the exact inserted range - a zero-mark content object degrades to the mark- inheriting typing path), so a drop inside a bold run or link label stays an independent plain-text URI - drops on the Preview tab switch back to Raw before inserting instead of writing into the hidden editor at an invisible caret - tab-drag cancel (Escape) now dispatches tab-drag-end so drop targets can never strand a document pointermove listener - successful PR mutations schedule a dedup-bypassing background reconciliation fetch, so an interrupted refresh no longer freezes commits/checks/files or the inline-comment head SHA anchor - request-id guards are scoped per PR key: switching PRs no longer discards an unrelated in-flight load's cache write - inline comment/reply paths gain try/catch, error surfacing, and a submitting flag, and never patch the cache on failure Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Neonforge98
added a commit
that referenced
this pull request
Jul 30, 2026
…cache fix(github): support PR session drops and fresh comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RichMarkdownEditor, insert at the active ProseMirror selection, and show the shared passive session pill preview immediately while keeping the canonical URI as the submitted markdown&round-tripping, rich-editor insertion, cache freshness, and post-close/reopen comment retentionVerification
pnpm typecheckpnpm test: 770 files / 6,823 testspnpm buildA747A43A5CCF32B38DF9082D77C539912696C99853AA28AB6328FB539D59D3312A5CB0D905DECB7C56D26B34916648FA640D95B0CEB5A8C6A539D52BBA7A6245Dual-instance Windows E2E
Validated with the default profile (
My Personal Org) and the isolated.orgii-instance2profile (CU Vanta Shares 0721):Review Agent Session Before Merginginto PR feat(runtime): add team runtime sharing #570 on Windowsorgii://cloud/session/refURI with no&; the passiveReview Age...pill appeared immediatelyTeam session 7094561cfallbackPerformance / UI audit
pointermoveis attached only for an active Session drag and removed on drag end/unmountcachedAt