Use semantic purple for merged pull requests - #716
Merged
Conversation
Harry19081
marked this pull request as ready for review
August 6, 2026 13:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Merged pull requests reuse the primary blue treatment, so their completed state is visually indistinguishable from ordinary primary actions and links across badges, summaries, sidebar indicators, and merge controls.
Solution
Add a semantic purple scale for light, dark, and high-contrast themes and expose it through Tailwind. Map the shared merged PR presentation to purple, add a merged Button variant with matching split-button interaction states, and use the same semantic status color in detail summaries, action controls, and sidebar indicators.
Potential risks
The new theme variables must remain present in every supported theme; missing variables in a downstream custom theme would cause merged treatments to lose color. Existing open, draft, and closed mappings are unchanged. Manual visual evidence for all three themes is pending, so this PR remains a draft.
Audit
The configured
frontend-ui-auditskill file was unavailable at both documented locations. A direct consistency pass confirmed that merged color ownership stays in the shared PR-status and Button primitives, with callers consuming semantic variants instead of duplicating raw color values.Verification
tailwind.config.jsis ignored by the repository ESLint configuration and produced one warning.pnpm typecheck— passed.git diff --cached --check— passed before commit.