Skip to content

Use semantic purple for merged pull requests - #716

Merged
sudomaggie merged 2 commits into
developfrom
dev/merged-pr-purple-status
Aug 6, 2026
Merged

Use semantic purple for merged pull requests#716
sudomaggie merged 2 commits into
developfrom
dev/merged-pr-purple-status

Conversation

@Harry19081

Copy link
Copy Markdown
Member

Problem

Merged pull requests reuse the primary blue treatment, so their completed state is visually indistinguishable from ordinary primary actions and links across badges, summaries, sidebar indicators, and merge controls.

Solution

Add a semantic purple scale for light, dark, and high-contrast themes and expose it through Tailwind. Map the shared merged PR presentation to purple, add a merged Button variant with matching split-button interaction states, and use the same semantic status color in detail summaries, action controls, and sidebar indicators.

Potential risks

The new theme variables must remain present in every supported theme; missing variables in a downstream custom theme would cause merged treatments to lose color. Existing open, draft, and closed mappings are unchanged. Manual visual evidence for all three themes is pending, so this PR remains a draft.

Audit

The configured frontend-ui-audit skill file was unavailable at both documented locations. A direct consistency pass confirmed that merged color ownership stays in the shared PR-status and Button primitives, with callers consuming semantic variants instead of duplicating raw color values.

Verification

  • Vitest for Button, PR status, session menu builders, and PR detail panel — passed (33 tests across 4 files).
  • ESLint on all changed JS/TS/TSX files — passed; tailwind.config.js is ignored by the repository ESLint configuration and produced one warning.
  • pnpm typecheck — passed.
  • git diff --cached --check — passed before commit.
  • Manual desktop verification was not run because local UI control was not authorized for this task.

@Harry19081
Harry19081 marked this pull request as ready for review August 6, 2026 13:00
@sudomaggie
sudomaggie merged commit 76e161b into develop Aug 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants