Draw outline box at look on the block

[Intezium]

Hello, I am trying to draw a box when looking at the block. What am I missing?

@Override
    public void onInitializeClient() {
        WorldRenderEvents.BEFORE_BLOCK_OUTLINE.register((worldRenderContext, blockOutlineContext) -> {
            Camera camera = worldRenderContext.camera();
            Vec3d blockPos = blockOutlineContext.getPos();

            Tessellator tessellator = RenderSystem.renderThreadTesselator();
            BufferBuilder vertexConsumer = tessellator.getBuffer();

            double cameraX = camera.getPos().getX();
            double cameraY = camera.getPos().getY();
            double cameraZ = camera.getPos().getZ();

            RenderSystem.setShader(GameRenderer::getPositionProgram);
            vertexConsumer.begin(VertexFormat.DrawMode.LINES, VertexFormats.POSITION_COLOR);

            WorldRenderer.drawBox(vertexConsumer, blockPos.getX() - cameraX, blockPos.getY() - cameraY, blockPos.getZ() - cameraZ, blockPos.getX() - cameraX + 1, blockPos.getY() - cameraY + 1, blockPos.getZ() - cameraZ + 1, 0, 0, 1, 0.75F);

            BufferRenderer.draw(vertexConsumer.end());
            return false;
        });
    }

[warjort]

I'm not familiar with the api you are using.
But fabric yarn adds this javadoc: https://github.com/FabricMC/yarn/blob/88a26049ebe29bf74c9938b9f4d3b4cff4d58c37/mappings/net/minecraft/client/render/BufferRenderer.mapping#L16

Is there a reason why you are trying to draw directly instead of just adding to the RenderLayer.LINES buffer?
See the code around the call to drawBlockOutline() in WorldRenderer.render() for how vanilla does it.

[Intezium]

Thanks for the tip! The reason is that I will be drawing more than just lines later.

[Intezium]

Working example for 1.19.4:

        WorldRenderEvents.BLOCK_OUTLINE.register((worldRenderContext, blockOutlineContext) -> {
            Vec3d cameraPos = worldRenderContext.camera().getPos();
            BlockPos blockPos = blockOutlineContext.blockPos();

            Vector4f color = new Vector4f(0,235/255f,235/255f, 1);
            float padding = 0.001f;

            float minBlockX = blockPos.getX() - padding;
            float minBlockY = blockPos.getY() - padding;
            float minBlockZ = blockPos.getZ() - padding;
            float maxBlockX = blockPos.getX() + padding + 1;
            float maxBlockY = blockPos.getY() + padding + 1;
            float maxBlockZ = blockPos.getZ() + padding + 1;

            MatrixStack matrixStack = worldRenderContext.matrixStack();
            matrixStack.push();
            matrixStack.translate(-cameraPos.getX(), -cameraPos.getY(), -cameraPos.getZ());

            Tessellator tessellator = RenderSystem.renderThreadTesselator();
            BufferBuilder bufferBuilder = tessellator.getBuffer();

            RenderSystem.setShader(GameRenderer::getPositionColorProgram);
            RenderSystem.enableDepthTest();

            bufferBuilder.begin(VertexFormat.DrawMode.DEBUG_LINES, VertexFormats.POSITION_COLOR);

            WorldRenderer.drawBox(
                    matrixStack,
                    bufferBuilder,
                    new Box(minBlockX, minBlockY, minBlockZ, maxBlockX, maxBlockY, maxBlockZ), color.x, color.y, color.z, color.w
            );

            tessellator.draw();
            matrixStack.pop();
            RenderSystem.disableDepthTest();
            return false;
        });