[26.2] Makin a horizontal directional block?

[bxtiivok]

Description

I'm trying to add pale versions of the pumpkin & carved pumpkin block but I can't get the horizontal directional property thing of the carved pale pumpkin to work & the texture just keeps giving up :P

Im very new to java so my code is probably messy
These are what I've currently got:

in Blocks.java:

public static final Block CARVED_PALE_PUMPKIN = register(
    BlockItemIds.CARVED_PALE_PUMPKIN,
    CarvedPalePumpkin::new,
    BlockBehaviour.Properties.of()
        .sound(SoundType.WOOD)
);

CarvedPalePumpkin.java:

public class CarvedPalePumpkin extends Block {

    public static final EnumProperty<Direction> FACING;

    protected CarvedPalePumpkin(final BlockBehaviour.Properties properties) {
        super(properties);
    }

    protected @NonNull BlockState rotate(final BlockState state, final Rotation rotation) {
        return state.setValue(FACING, rotation.rotate(state.getValue(FACING)));
    }
    protected @NonNull BlockState mirror(final BlockState state, final Mirror mirror) {
        return state.rotate(mirror.getRotation(state.getValue(FACING)));
    }

    static {
        FACING = BlockStateProperties.HORIZONTAL_FACING;
    }
}

assets/pale-renaissance/blockstates/carved_pale_pumpkin.json:

{
  "variants": {
    "facing=north": {
      "model": "pale-renaissance:block/carved_pale_pumpkin"
    },
    "facing=east":  {
      "model": "pale-renaissance:block/carved_pale_pumpkin",
      "y":  90
    },
    "facing=south": {
      "model": "pale-renaissance:block/carved_pale_pumpkin",
      "y": 180
    },
    "facing=west":  {
      "model": "pale-renaissance:block/carved_pale_pumpkin",
      "y": 270
    }
  }
}

assets/pale-renaissance/models/block/carved_pale_pumpkin.json:

{
  "parent": "minecraft:block/cube_all",
  "textures": {
    "up": "pale-renaissance:block/pale_pumpkin_top",
    "down": "pale-renaissance:block/pale_pumpkin_top",
    "north": "pale-renaissance:block/pale_pumpkin_carved",
    "south": "pale-renaissance:block/pale_pumpkin_side",
    "east": "pale-renaissance:block/pale_pumpkin_side",
    "west": "pale-renaissance:block/pale_pumpkin_side",
    "particle": "pale-renaissance:block/pale_pumpkin_carved"
  }
}

I'm not sure what I'm doin wrong..
I get warns for the "facing" property not existing even though I have implemented that in CarvedPalePumpkin (i think??)
And on the pic on top, the texture loads correctly in the hotbar so that just confuses me even more </3
Any help appreciated, thanks in advance!!

[bxtiivok]

Figured it out :3
I was missin' the getStateForPlacement() and/or createBlockStateDefinition() methods in my class!

public class CarvedPalePumpkinBlock extends HorizontalDirectionalBlock {
    public static final MapCodec<CarvedPalePumpkinBlock> CODEC = simpleCodec(CarvedPalePumpkinBlock::new);
    public static final EnumProperty<Direction> FACING;

    public @NonNull MapCodec<? extends CarvedPalePumpkinBlock> codec() {
        return CODEC;
    }

    public CarvedPalePumpkinBlock(final BlockBehaviour.Properties properties) {
        super(properties);
        this.registerDefaultState(this.stateDefinition.any().setValue(FACING, Direction.NORTH));
    }

    public BlockState getStateForPlacement(final BlockPlaceContext context) {
        return this.defaultBlockState().setValue(FACING, context.getHorizontalDirection().getOpposite());
    }

    protected void createBlockStateDefinition(final StateDefinition.Builder<Block, BlockState> builder) {
        builder.add(FACING);
    }

    static {
        FACING = HorizontalDirectionalBlock.FACING;
    }
}