Replies: 1 comment 1 reply
-
|
Make sense. Can you please send a PR for the same? https://github.com/adonisjs/http-server |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
router.makeSignedUrlis deprecated in favor ofsignedUrlFor, but the new URL builder API does not seem to support the olddisableRouteLookupbehavior.This removes a useful workflow: signing an external URL or a route pattern that is not registered in the current app router.
Current Workaround
This still works, but uses a deprecated API:
Problem With The New API
signedUrlForrequires a registered route identifier. Passing a route pattern fails because the implementation performs a router lookup.In a setup where previews are served by a separate preview server, this is limiting. For example:
localhost:3000localhost:4000Expected Behavior
It would be helpful to have a non-deprecated way to sign an external URL pattern without registering a mirror route in the current app.
For example:
Or with a named option:
Why This Matters
Without this, the available workarounds are not ideal:
router.makeSignedUrl.The old behavior was useful for external signed URLs, preview systems, multi-app deployments, and any architecture where one service signs access to URLs served by another service.
Beta Was this translation helpful? Give feedback.
All reactions