feat: support signed URL patterns without route lookup#129
Open
0xtlt wants to merge 2 commits into
Open
Conversation
6 tasks
thetutlage
reviewed
Jul 8, 2026
| ...[identifier, params, options] | ||
| const signedRoute: SignedUrlFor<Routes> = function route( | ||
| identifier: string, | ||
| params?: any[] | Record<string, any>, |
Member
There was a problem hiding this comment.
We can make the params type-safe too by using the https://github.com/poppinss/types/blob/1.x/src/route.ts#L50 from the types package
Author
|
@thetutlage Done, I used Does it look good now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Discussion: https://github.com/orgs/adonisjs/discussions/5126
❓ Type of change
📚 Description
This PR adds support for generating signed URLs from route patterns without performing a route lookup.
It restores the
disableRouteLookupbehavior for the typedsignedUrlForhelper, matching the legacyrouter.makeSignedUrl(..., { disableRouteLookup: true })API.Example:
When
disableRouteLookupis enabled, the first argument is parsed as a route pattern and signed directly. RegularsignedUrlForcalls still use route lookup and keep their existing route-name type safety.This also adds runtime and type-level coverage for the new behavior.
Docs PR: adonisjs/v7-docs#67
📝 Checklist