highlight.js update to support highlighting the Jai language #207894
Replies: 6 comments
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
|
There are two separate pipelines here. GitHub documents that it uses Linguist for language detection and to select third-party grammars for syntax highlighting; GitHub.com highlighting is based on TextMate-compatible grammars, not directly on highlight.js. Jai is already present in Linguist and currently maps Also, highlightjs/highlight.js#4536 currently adds only one row to If the goal is GitHub.com code highlighting, the relevant path is to improve or replace Jai's grammar in |
This comment was marked as low quality.
This comment was marked as low quality.
From what I've seen, GitHub doesn't track highlight.js releases very closely — they run a pinned/patched version and bump it every few months at best, sometimes longer. I remember a while back their highlighted version lagged the upstream releases by quite a bit, and I don't think that's changed much. They also carry their own local patches, so "merged upstream" and "shipping on GitHub" aren't the same event. |
|
Thanx for the input. It's published to npm already too. |
|
Publishing More importantly, GitHub.com's relevant public integration is already elsewhere: GitHub Linguist currently recognizes If a concrete Jai file is highlighted incorrectly on GitHub, the actionable next step is a minimal public |
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Product Feedback
💬 Feature/Topic Area
Code Search and Navigation
Body
I understand GitHub uses highlight.js to apply syntax highlighting. I have completed a highlight.js language definition for the Jai language, and it's PR into the main repo (highlightjs/highlight.js#4536) is ready for merging, I am wondering how often GitHub updates its highlight.js dependency, so I might know how soon this will become part of GitHub.
If this is not the right place for this query/request please let me know where I should put it. Thanx. (c:
All reactions