GitHub Actions triggers workflow with pull_request_review edited event even if not listening to it, when commenting

[ldeluigi]

image927×442 20.2 KB

As you can see, my workflow was triggered with a pull_request_review edited event after I submitted a pull_request_review with comments.

The problem is that in my workflow file I’m listening only to created comments and submitted (not edited) reviews:

image831×637 12.3 KB

[ldeluigi]

After I SUBMITTED a review with 2 comments and a body, my workflow triggered 4 times, instead of 3:

1. One time with pull_request_review submitted, with the correct body of the review
2. One time with pull_request_review_comment created, with the correct body of the first comment
3. One time with pull_request_review_comment created, with the correct body of the second comment
4. One time with pull_request_review edited, with the correct body of the review, but I wasn’t listening for that event

[otter-computer]

I believe this is caused by a typo in your workflow file. It looks like you’ve used type instead of types for both pull_request_review and pull_request_review_comment. This means that your workflow will listen to all default triggers for these events.

If you change both instances to types then it should only listen for the events specified in the array.

I’m surprised the workflow editor doesn’t flag this as an error or at least show a warning though. I’ll pass this on to the editor team and see if there’s an open issue for it.