std: implement hostname using GetHostNameW on Windows, #1
Merged
orowith2os merged 1 commit intoorowith2os:std-net-gethostnamefrom Jan 24, 2025
Merged
Conversation
…code resilient against bad platform behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
..and make the UNIX code resilient against bad platform behaviour.
std's tests need to pass on Windows, sohostnamemust be implemented there before rust-lang#135141 can be merged. I also took the opportunity to correct some of the UNIX code,gethostnamehas some very weird behaviour on some platforms, this change should make the implementation resilient against that.