Skip to content

chore: fix typo#180

Merged
aeneasr merged 2 commits intoory:masterfrom
vinckr:patch-1
Jun 21, 2022
Merged

chore: fix typo#180
aeneasr merged 2 commits intoory:masterfrom
vinckr:patch-1

Conversation

@vinckr
Copy link
Copy Markdown
Member

@vinckr vinckr commented Jun 20, 2022

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented Jun 21, 2022

@vinckr you only updated the test, not the actual message :) you need to update both

fix in actual code not just in test
@vinckr
Copy link
Copy Markdown
Member Author

vinckr commented Jun 21, 2022

woops 😅
for some reason it only found the one typo when searching.

should be good now 👍

@aeneasr aeneasr merged commit 4a51388 into ory:master Jun 21, 2022
@vinckr vinckr deleted the patch-1 branch June 21, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants