Skip to content

feat: new email styles#186

Merged
aeneasr merged 10 commits intoory:masterfrom
vinckr:patch-1
Aug 15, 2022
Merged

feat: new email styles#186
aeneasr merged 10 commits intoory:masterfrom
vinckr:patch-1

Conversation

@vinckr
Copy link
Copy Markdown
Member

@vinckr vinckr commented Aug 2, 2022

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

@vinckr vinckr marked this pull request as draft August 2, 2022 12:08
@vinckr vinckr marked this pull request as ready for review August 2, 2022 15:35
@vinckr vinckr marked this pull request as draft August 3, 2022 10:31
@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented Aug 3, 2022

@vinckr is the report still running? or is it finished? if it is finished should we keep the questionaire in or not?

@vinckr
Copy link
Copy Markdown
Member Author

vinckr commented Aug 3, 2022

@vinckr is the report still running? or is it finished? if it is finished should we keep the questionaire in or not?

sorry yea I would keep the questionaire for at least the Hydra 2.0 release. We just used slack&socials so far, so the survey would reach a lot more people who arent active there.

@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented Aug 13, 2022

ping @vinckr

@vinckr
Copy link
Copy Markdown
Member Author

vinckr commented Aug 15, 2022

Can you point me to how to generate the correct stub for testing the email body @aeneasr? I used the output in mailchimp but the formatting seems to be off...

It also seems to be testing against the old version still no matter how I change changelog.html.expected.

@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented Aug 15, 2022

You need to run the test, rename changelog.html.tmp to changelog.html.expected, run the test again -> it works

@vinckr vinckr marked this pull request as ready for review August 15, 2022 17:54
@vinckr
Copy link
Copy Markdown
Member Author

vinckr commented Aug 15, 2022

ahh ty, works now :D
i totally missed the changelog.html.tmp

@aeneasr aeneasr merged commit 6afa6c9 into ory:master Aug 15, 2022
@vinckr vinckr deleted the patch-1 branch September 15, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants