Skip to content

chore: golangci-lint 1.48#193

Merged
aeneasr merged 2 commits intomasterfrom
unknown repository
Aug 18, 2022
Merged

chore: golangci-lint 1.48#193
aeneasr merged 2 commits intomasterfrom
unknown repository

Conversation

@kevgo
Copy link
Copy Markdown
Contributor

@kevgo kevgo commented Aug 18, 2022

A new version of golangci-lint came out, I'm upgrading to it while fixing all linter warnings.

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

@kevgo kevgo changed the title Golangci-lint 1.48 chore: golangci-lint 1.48 Aug 18, 2022
Comment thread Makefile
GOBIN=$(PWD)/.bin/ go install $1
endef
$(foreach dep, $(GO_DEPENDENCIES), $(eval $(call make-go-dependency, $(dep))))
$(call make-lint-dependency)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to call something non-existing.

@aeneasr aeneasr merged commit 7876563 into ory:master Aug 18, 2022
@kevgo kevgo deleted the kg-remove-linter-warnings branch August 18, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants