fix: force-remove containers on pool cleanup, add ref-counting tests#653
Merged
fix: force-remove containers on pool cleanup, add ref-counting tests#653
Conversation
Pool.cleanup() previously called resource.Close() which respects reference counting, leaving reused containers running when the pool shuts down. Now cleanup bypasses ref counting and force-removes all tracked containers. Adds 5 tests covering the cleanup API and ref-counting behavior: - TestResourceCloseRefCounting (integration) - TestPoolCloseT (integration) - TestPoolCleanupForceRemovesReusedContainers (integration) - TestCheckForExistingIncrementsRefCount (unit) - TestGetWithScopeDoesNotIncrementRefs (unit) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pool.cleanup()to force-remove containers regardless of reference count. Previously, cleanup calledresource.Close()which respects ref counting, leaving reused containers running when a pool shuts down.Tests added
TestResourceCloseRefCountingrun_test.goTestPoolCloseTpool_test.goTestPoolCleanupForceRemovesReusedContainerspool_test.goTestCheckForExistingIncrementsRefCountpool_test.goTestGetWithScopeDoesNotIncrementRefsregistry_test.goTest plan
go test -short -run 'TestGetWithScopeDoesNotIncrementRefs|TestCheckForExistingIncrementsRefCount' -v -count=1— unit tests passgo test -run 'TestResourceCloseRefCounting|TestPoolCloseT|TestPoolCleanupForceRemovesReusedContainers' -v -count=1— integration tests passgo test -v -count=1 ./...— full suite passes with no regressions🤖 Generated with Claude Code