Skip to content

Conversation

@gaultier
Copy link
Contributor

Related Issue or Design Document

https://github.com/ory-corp/cloud/pull/8571

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@gaultier gaultier changed the title docs: document new project revision field submix_max docs: document new project revision field submit_max May 28, 2025
@gaultier gaultier enabled auto-merge (squash) May 28, 2025 08:14
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but normally we don't edit the API docs directly bc they would get overwritten by automatic update. Maybe this changed with the monorepo setup?

@gaultier
Copy link
Contributor Author

looks good but normally we don't edit the API docs directly bc they would get overwritten by automatic update. Maybe this changed with the monorepo setup?

TIL, what's the recommended way to update the docs then in this case?

@aeneasr
Copy link
Member

aeneasr commented May 30, 2025

You need to find the string in the handler.go file (typically it's there) and update the code doc referencing it :)

@aeneasr
Copy link
Member

aeneasr commented May 30, 2025

In this case probably actually nothing needs to be done, it just hasn't synched yet, maybe?

@gaultier gaultier closed this Jun 3, 2025
auto-merge was automatically disabled June 3, 2025 12:29

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants