chore(docs): Remove unsupported settings hook from verified address docs #2313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no sign of support for doing what was described in the documentation. The config schema suggests only "webhook" is allowed in definitions/selfServiceAfterSettingsMethod. In Kratos, I also do not see any sign of a ExecuteSettingsPostPersistHook method in address_verifier.go so do not understand how this could have ever worked.
lol768
changed the title
Author
zepatrik
requested changes
Oct 9, 2025
Member
zepatrik
left a comment
zepatrik
left a comment
There was a problem hiding this comment.
It seems this was introduced but is not yet released officially in open source. What version of Kratos are you running?
ory/kratos@c433c44
Author
|
Thanks, that's useful context (had missed that diff when looking through the codebase) - running latest available tagged Is it worth covering this in the documentation? |
Member
|
We're working on improving versioning and the split between Ory Network and Open Source versions, so while it is confusing right now, we will hopefully have a better docs structure in the future that makes this clear. I'll close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no sign of support for doing what was described in the documentation. The config schema suggests only "webhook" is allowed in definitions/selfServiceAfterSettingsMethod. In Kratos, I also do not see any sign of a ExecuteSettingsPostPersistHook method in address_verifier.go so do not understand how this could have ever worked.
This appears to have tripped multiple people up: https://ory-community.slack.com/archives/C0522079BS5/p1753886141446629?thread_ts=1753886038.426959&cid=C0522079BS5