Skip to content

Conversation

@niwsa
Copy link
Contributor

@niwsa niwsa commented Oct 27, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@niwsa niwsa marked this pull request as ready for review October 29, 2025 10:01
@niwsa niwsa changed the title feat: Google SCIM feat: document Google SCIM Oct 29, 2025
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! looks great already,
some minor style comments, but otherwise looks good to me.

I haven't tested this though.

One other thing to think about: there are quite a lot of screenshots in this doc - how can we make sure these are up to date? Ideally it would be automated, but in general it's an unsolved problem for the docs. Maybe @unatasha8 has an idea how we can keep screenshots up to date without much manual work.

otherwise looks good to me!

@vinckr vinckr requested a review from unatasha8 October 29, 2025 12:14
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@niwsa niwsa merged commit 39ead55 into master Nov 4, 2025
9 checks passed
@niwsa niwsa deleted the google-scim branch November 4, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants