Skip to content

chore: remove absolute ory.com urls trailing slash#2366

Merged
jaygiang merged 4 commits into
masterfrom
chore/clean-up-links
Nov 26, 2025
Merged

chore: remove absolute ory.com urls trailing slash#2366
jaygiang merged 4 commits into
masterfrom
chore/clean-up-links

Conversation

@jaygiang
Copy link
Copy Markdown
Collaborator

Remove trailing slashes from absolute ory.com URLs to prevent unnecessary redirects

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Copy Markdown
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I'm blind but there doesn't seem to be a trailing slash here in the first place? and your change is just formatting?

@jonas-jonas
Copy link
Copy Markdown
Member

@vinckr each of these changes is removing a / from the end of URLs
image

Copy link
Copy Markdown
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@vinckr
Copy link
Copy Markdown
Member

vinckr commented Nov 26, 2025

wth i only saw 1 change and that was just formatting - now I see all 19 changed files...
i blame github 😅

@jaygiang jaygiang merged commit 63a5334 into master Nov 26, 2025
9 checks passed
@jaygiang jaygiang deleted the chore/clean-up-links branch November 26, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants