Skip to content

fix: typo in account linking mode description#2535

Merged
vinckr merged 2 commits intoory:masterfrom
KT-Doan:patch-1
Apr 30, 2026
Merged

fix: typo in account linking mode description#2535
vinckr merged 2 commits intoory:masterfrom
KT-Doan:patch-1

Conversation

@KT-Doan
Copy link
Copy Markdown
Contributor

@KT-Doan KT-Doan commented Apr 29, 2026

verify_with_existing_credential should be confirm_with_existing_credential based on API Spec.

Related Issue or Design Document

Based on https://github.com/ory/kratos/blob/88a838d879394ab218b24ec01deb63c77b8fe480/selfservice/strategy/oidc/provider_config.go#L21-L25

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copilot AI review requested due to automatic review settings April 29, 2026 05:30
@KT-Doan KT-Doan changed the title Fix typo in account linking mode description fix: typo in account linking mode description Apr 29, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Kratos social sign-in documentation to align the account_linking_mode value name with the API specification.

Changes:

  • Replace verify_with_existing_credential with confirm_with_existing_credential in the account linking mode table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/kratos/social-signin/95_account-linking.mdx Outdated
KT-Doan added 2 commits April 30, 2026 09:15
verify_with_existing_credential should be confirm_with_existing_credential based on API Spec.
Prettier realigned the markdown table column spacing in
95_account-linking.mdx after the wire-value correction.
@vinckr vinckr enabled auto-merge (squash) April 30, 2026 12:16
@vinckr vinckr merged commit d86fdb6 into ory:master Apr 30, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants