Skip to content

feat: add password toggle to input#378

Merged
jonas-jonas merged 2 commits intomainfrom
jonas-jonas/addEyeIconPWFields
Mar 6, 2025
Merged

feat: add password toggle to input#378
jonas-jonas merged 2 commits intomainfrom
jonas-jonas/addEyeIconPWFields

Conversation

@jonas-jonas
Copy link
Copy Markdown
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Mar 5, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 49.43%. Comparing base (f3fad4d) to head (e1d9df7).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   42.43%   49.43%   +6.99%     
==========================================
  Files         136      140       +4     
  Lines        2008     2193     +185     
  Branches      288      333      +45     
==========================================
+ Hits          852     1084     +232     
+ Misses       1149     1096      -53     
- Partials        7       13       +6     
Components Coverage Δ
@ory/elements-react 46.09% <35.12%> (+9.30%) ⬆️
@ory/nextjs 64.33% <74.24%> (-1.65%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jonas-jonas jonas-jonas merged commit 0df7992 into main Mar 6, 2025
11 of 12 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/addEyeIconPWFields branch March 6, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants