Skip to content

Scaffold controller#12

Merged
Tomasz-Smelcerz-SAP merged 4 commits intoory:masterfrom
jakkab:scaffold-controller
Aug 29, 2019
Merged

Scaffold controller#12
Tomasz-Smelcerz-SAP merged 4 commits intoory:masterfrom
jakkab:scaffold-controller

Conversation

@jakkab
Copy link
Copy Markdown
Contributor

@jakkab jakkab commented Aug 26, 2019 •
edited
Loading

Changes:

  • commit 1:
    • scaffold controller
  • commit 2:
    • api
    • basic controller logic
    • hydra client CRUD
    • validation
    • happy path integration test
    • enable ci

@jakkab jakkab force-pushed the scaffold-controller branch 2 times, most recently from 24dab0e to 0ac3242 Compare August 26, 2019 08:28
Demonsthere
Demonsthere requested changes Aug 26, 2019
View reviewed changes
Comment thread api/v1alpha1/oauth2client_types.go Outdated
Comment thread config/crd/kustomization.yaml
Comment thread config/default/manager_image_patch.yaml-e Outdated
@jakkab jakkab force-pushed the scaffold-controller branch from b179965 to 735de9d Compare August 26, 2019 13:42
Tomasz-Smelcerz-SAP
Tomasz-Smelcerz-SAP suggested changes Aug 27, 2019
View reviewed changes
Comment thread api/v1alpha1/oauth2client_json.go
Comment thread controllers/oauth2client_controller.go
Comment thread controllers/oauth2client_controller_test.go Outdated
Comment thread controllers/oauth2client_controller.go
@jakkab jakkab force-pushed the scaffold-controller branch from c83b27b to 7586640 Compare August 27, 2019 13:13
@jakkab jakkab force-pushed the scaffold-controller branch from b96ef71 to cd78361 Compare August 28, 2019 10:59
@jakkab jakkab marked this pull request as ready for review August 28, 2019 11:13
aeneasr
aeneasr approved these changes Aug 28, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakkab jakkab force-pushed the scaffold-controller branch from 176c63b to 5b5a8f9 Compare August 29, 2019 09:29
@jakkab jakkab force-pushed the scaffold-controller branch from d7c39d9 to 1c96781 Compare August 29, 2019 11:01
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP merged commit 0cecfbb into ory:master Aug 29, 2019
This was referenced Sep 13, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aeneasr aeneasr aeneasr approved these changes

@Demonsthere Demonsthere Demonsthere approved these changes

+1 more reviewer

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jakkab @aeneasr @Demonsthere @Tomasz-Smelcerz-SAP