Don't push to coveralls in CI when PR comes from fork

[aeneasr]

See https://circleci.com/gh/ory/hydra/1225?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

[aeneasr]

So the issue is that forked repos also try to push to coveralls, which fails, as the forked repo is not registered at coveralls. There are two ways to fix this:

1. See if we can add a check based on Circle CI's environment variables that prevents coveralls push when we're building a fork. (preferred option)
2. Don't fail the tests when coveralls push fails. This should be the fallback option that we use if 1 fails.

[zepatrik]

Does goveralls run the test or is it in it's own command? Is replacing this line with something like

[ -z "$CIRCLE_PR_NUMBER" ] && goveralls -service=circle-ci -coverprofile=coverage.txt -repotoken=$COVERALLS_REPO_TOKEN || echo "forks are not allowed to push to coveralls"

enough?
In the goveralls repo it says that goveralls runs the test suit.

[aeneasr]

It doesn't run the test suite in our case - so something like that should work. But I still want code coverage for PRs, just not for the ones from forked repos :)

[zepatrik]

Sure, as you can see in your link above CIRCLE_PR_NUMBER, CIRCLE_PR_REPONAME and CIRCLE_PR_USERNAME are only available in forked PR builds. So checking if any of these variables is set should determine if the build is from a fork.

[aeneasr]

Ah nice! I missed that :)

[aeneasr]

Actually, maybe removing the repotoken is already enough!

For a public github repository, it is not necessary to define your repository key (COVERALLS_TOKEN).

Can you try that (without [ -z "$CIRCLE_PR_NUMBER" ] && )?