travis: Only gox build on tags and go1.7

[emilva]

Issue #285

Not sure if this fix will work or not, as I could not get it building on my forked repo in travis-ci.
Anyways, something like this should do the trick

[aeneasr]

I think there's still an issue with the travis file:

/home/travis/build.sh: eval: line 46: syntax error: unexpected end of file

https://travis-ci.org/ory-am/hydra/jobs/165746289#L882

[aeneasr]

It looks like travis executes this as a one-liner which probably causes the issues.

[emilva]

Yeah, will look into that

On 7 October 2016 at 10:54, Aeneas notifications@github.com wrote:

I think there's still an issue with the travis file:

/home/travis/build.sh: eval: line 46: syntax error: unexpected end of file

https://travis-ci.org/ory-am/hydra/jobs/165746289#L882

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#288 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZwplOZz1C3OVhatkFdnNPEbIyzmvLfks5qxgi6gaJpZM4KQf99
.

Best regards

Emil Vaagland

Software Engineer

Schibsted Products & Technology Oslo http://www.schibsted.com

Mob +4792668890

[aeneasr]

Looks like the issue persists: https://travis-ci.org/ory-am/hydra/jobs/165755242#L883

Are you sure that you can use raw bash in the travis config? Maybe you need to create a little bash script and call it from travis.yml instead.

[boyvinall]

you can probably use bash as long as it's inside the yaml array. Something like:

after_success:
- [ "${TRAVIS_TAG}" != "" ] && [ "${TRAVIS_GO_VERSION}" == "1.7" ] && gox -ldflags "-X github.com/ory-am/hydra/cmd.Version=`git describe --tags` -X github.com/ory-am/hydra/cmd.BuildTime=`TZ=UTC date -u '+%Y-%m-%dT%H:%M:%SZ'` -X github.com/ory-am/hydra/cmd.GitHash=`git rev-parse HEAD`" -output "dist/ {.Dir}}-{{.OS}}-{{.Arch}}"

except ... you need to ensure the leading [ isn't seen as a yaml token, so maybe some sort of heredoc:

after_success:
- |-
  [ "${TRAVIS_TAG}" != "" ] && [ "${TRAVIS_GO_VERSION}" == "1.7" ] && gox -ldflags "-X github.com/ory-am/hydra/cmd.Version=`git describe --tags` -X github.com/ory-am/hydra/cmd.BuildTime=`TZ=UTC date -u '+%Y-%m-%dT%H:%M:%SZ'` -X github.com/ory-am/hydra/cmd.GitHash=`git rev-parse HEAD`" -output "dist/ {.Dir}}-{{.OS}}-{{.Arch}}"

[aeneasr]

Cool, it doesn't throw any errors any more. Not sure if it really works though, yet :D Thanks for the hard work so far. I'll merge it and see what happens!

[emilva]

yeah, should be ok now! Tested the bash syntax in another project, and it worked as expected.

[aeneasr]

awesome, thanks so much :)