Skip to content

docker: --name should be before the image's name#316

Merged
aeneasr merged 1 commit intoory:masterfrom
bbigras:my-hydra
Dec 1, 2016
Merged

docker: --name should be before the image's name#316
aeneasr merged 1 commit intoory:masterfrom
bbigras:my-hydra

Conversation

@bbigras
Copy link
Copy Markdown
Contributor

@bbigras bbigras commented Dec 1, 2016

Usage: docker run [OPTIONS] IMAGE [COMMAND] [ARG...]

Without this commit, the container name is not 'my-hydra'. As --name is an option it should be before the image's name.

@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented Dec 1, 2016

Thanks! Please sign your commit with git commit --amend -s :)

@bbigras
docker: --name should be before the image's name
c12dc1d 
Signed-off-by: Bruno Bigras <bigras.bruno@gmail.com>
@bbigras
Copy link
Copy Markdown
Contributor Author

bbigras commented Dec 1, 2016

Please sign your commit with git commit --amend -s

Done.

@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented Dec 1, 2016

thanks!

@aeneasr aeneasr merged commit 9a71e18 into ory:master Dec 1, 2016
@bbigras bbigras deleted the my-hydra branch December 1, 2016 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bbigras @aeneasr