Skip to content

Comments

feat: add session cookie path configuration#3475

Merged
aeneasr merged 2 commits intoory:masterfrom
sgal:feat-cookie-path-configuration
Mar 27, 2023
Merged

feat: add session cookie path configuration#3475
aeneasr merged 2 commits intoory:masterfrom
sgal:feat-cookie-path-configuration

Conversation

@sgal
Copy link
Contributor

@sgal sgal commented Mar 25, 2023

Related issue(s)

Fixes #3473

Adds a configuration of a session cookie path, for setups where Hydra is served through a shared domain.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #3475 (31ae83a) into master (a663927) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 31ae83a differs from pull request most recent head 29ceb95. Consider uploading reports for the commit 29ceb95 to get more accurate results

@@            Coverage Diff             @@
##           master    #3475      +/-   ##
==========================================
- Coverage   76.83%   76.81%   -0.02%     
==========================================
  Files         123      123              
  Lines        9125     9127       +2     
==========================================
  Hits         7011     7011              
- Misses       1666     1669       +3     
+ Partials      448      447       -1     
Impacted Files Coverage Δ
driver/registry_base.go 85.93% <ø> (ø)
consent/strategy_default.go 69.50% <100.00%> (ø)
driver/config/provider.go 81.99% <100.00%> (+0.13%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sgal sgal changed the title feat:add session cookie path configuration feat: add session cookie path configuration Mar 25, 2023
@sgal sgal marked this pull request as ready for review March 25, 2023 12:38
@sgal sgal requested a review from aeneasr as a code owner March 25, 2023 12:38
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! For this to work though, you'll need to add this new config key to the config json schema: https://github.com/ory/hydra/blob/master/spec/config.json

@sgal
Copy link
Contributor Author

sgal commented Mar 26, 2023

Fixed the config and the description.

@aeneasr aeneasr merged commit af9fa81 into ory:master Mar 27, 2023
harnash pushed a commit to Wikia/ory-hydra that referenced this pull request Apr 12, 2023
Fixes ory#3473

Adds a configuration of a session cookie path, for setups where Hydra is served through a shared domain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration of the session cookie path for more granular security

2 participants