feat: add session cookie path configuration#3475
Merged
aeneasr merged 2 commits intoory:masterfrom Mar 27, 2023
sgal:feat-cookie-path-configuration
Merged
feat: add session cookie path configuration#3475aeneasr merged 2 commits intoory:masterfrom sgal:feat-cookie-path-configuration
aeneasr merged 2 commits intoory:masterfrom
sgal:feat-cookie-path-configuration
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3475 +/- ##
==========================================
- Coverage 76.83% 76.81% -0.02%
==========================================
Files 123 123
Lines 9125 9127 +2
==========================================
Hits 7011 7011
- Misses 1666 1669 +3
+ Partials 448 447 -1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aeneasr
requested changes
Mar 26, 2023
Member
aeneasr
left a comment
There was a problem hiding this comment.
This looks good to me! For this to work though, you'll need to add this new config key to the config json schema: https://github.com/ory/hydra/blob/master/spec/config.json
Contributor
Author
|
Fixed the config and the description. |
aeneasr
approved these changes
Mar 27, 2023
harnash
pushed a commit
to Wikia/ory-hydra
that referenced
this pull request
Apr 12, 2023
Fixes ory#3473 Adds a configuration of a session cookie path, for setups where Hydra is served through a shared domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Fixes #3473
Adds a configuration of a session cookie path, for setups where Hydra is served through a shared domain.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments