Conversation
added 9 commits
February 20, 2016 11:23
aeneasr
pushed a commit
that referenced
this pull request
Mar 11, 2016
Hydra is now using Go 1.6 vendoring and is deployable to heroku
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following BC breaks:
JWT_PUBLIC_KEY_PATHis nowJWT_PUBLIC_KEY.JWT_PRIVATE_KEY_PATHis nowJWT_PRIVATE_KEY.TLS_CERT_PATHis nowTLS_CERT.TLS_KEY_PATHis nowTLS_KEY_PATH.In all cases, it is now possible to pass the certificate directly as value, instead as a path. Hydra first checks if the given value is a path and if the file exists. If not, it tries to parse the value as the corresponding key.
Additionally, dependencies have been freezed which might cause issues when running
go test ./...(see issue go#11659, go#14417). As a workaround you can rungo <cmd> -t $(go list ./... | grep -v /vendor/)for now wherecmdcan betest,installand so on. I do not have a solution workaround for Windows.Having multiple executables and no executables in the root directory requires us to use
godep save ./cli/...and notgodep save ./...as the second one will destroy the build.ping @leetal