Skip to content

Client secret expires#870

Merged
aeneasr merged 7 commits intoory:masterfrom
zepatrik:client-secret-expires
May 25, 2018
Merged

Client secret expires#870
aeneasr merged 7 commits intoory:masterfrom
zepatrik:client-secret-expires

Conversation

@zepatrik
Copy link
Copy Markdown
Member

introduces the client_secret_expires_at field without any functionality
it should always be 0
closes #778

@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented May 23, 2018

Tests fail

Copy link
Copy Markdown
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zepatrik please add a test that checks if client_secret_expires_at is properly stored in the storage adapter by making changes to manager_test

@aeneasr aeneasr merged commit 56aa5d2 into ory:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

client: Add field client_secret_expires_at to create

2 participants