Conversation
…ustom models Allows users to run unlisted embedding models (quantized variants, local fine-tunes, models on non-standard ports) without forking or modifying KnownModels. Both variables are independently overridable — LUMEN_EMBED_DIMS is required for unknown models; LUMEN_EMBED_CTX overrides context length for any model and defaults to 8192 for unlisted ones. Adds table-driven TestLoad covering: known model (no overrides, each variable independently, both), unknown model (DIMS only, DIMS+CTX, neither → error, CTX-only → error). Documents new env vars and custom model usage in README. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove the `github.actor != 'release-please[bot]'` guards so CI jobs run on autorelease PRs — required for branch protection checks to pass before merging. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
GitHub suppresses pull_request events when a PR is opened via GITHUB_TOKEN, so CI never runs on release-please PRs. Passing a PAT via RELEASE_PLEASE_TOKEN causes the PR to be opened as a real actor, which does trigger the pull_request event and CI. Requires a RELEASE_PLEASE_TOKEN secret (PAT with contents:write and pull-requests:write) to be added to the repo. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
Closing — going with the branch protection bypass list approach instead (no code change needed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.actor != 'release-please[bot]'guards from all three CI jobs (test,lint,e2e)Fixes the issue seen in #85 where branch protection checks can't pass.
Test plan
🤖 Generated with Claude Code