Skip to content

Conversation

@chungshien-chai
Copy link
Collaborator

@chungshien-chai chungshien-chai commented Sep 23, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

This PR drastically change the way IO routing bits setting generation flow:

  • Old way is to model all the routable resources in device dedicated config mapping file (each device has different resources), and C code read those information and do the routing in C code

  • New way is to use Python script model the circuitry/block-diagram of routable resouces, during bitstream generation, C code will just need to give enough information to Python script for example: start node, essential node, end node etc, the Python will do the routing based on the model

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

@codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 73.99381% with 168 lines in your changes missing coverage. Please review.

Project coverage is 14.46%. Comparing base (d8ddcde) to head (1fb1812).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/Configuration/ModelConfig/ModelConfig_IO.cpp 74.62% 7 Missing and 128 partials ⚠️
src/Configuration/ModelConfig/ModelConfig.cpp 72.72% 4 Missing and 14 partials ⚠️
src/Compiler/CompilerOpenFPGA.cpp 0.00% 10 Missing ⚠️
src/Configuration/CFGCommon/CFGCommon.cpp 80.95% 0 Missing and 4 partials ⚠️
src/Configuration/ModelConfig/ModelConfig_IO.h 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1706      +/-   ##
==========================================
- Coverage   14.77%   14.46%   -0.32%     
==========================================
  Files         480      478       -2     
  Lines       64028    63809     -219     
  Branches    26287    26119     -168     
==========================================
- Hits         9461     9230     -231     
+ Misses      53339    53326      -13     
- Partials     1228     1253      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chungshien-chai chungshien-chai marked this pull request as ready for review September 27, 2024 08:14
@alaindargelas alaindargelas merged commit 5cf4644 into main Sep 27, 2024
@alaindargelas alaindargelas deleted the feodag-routing-model branch September 27, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants