Skip to content

Add osac-metering-service repository - #127

Merged
larsks merged 1 commit into
osac-project:mainfrom
masayag:add-osac-metering-service
Jul 14, 2026
Merged

Add osac-metering-service repository#127
larsks merged 1 commit into
osac-project:mainfrom
masayag:add-osac-metering-service

Conversation

@masayag

@masayag masayag commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add osac-metering-service repository configuration to org-managed repos
  • Teams: fulfillment-wg (push), observability-wg (push), wg-infra (admin)
  • Full CI setup: bot merge via openshift-merge-robot, e2e-test environment, no required approvals

Test plan

  • Verify pre-commit CI check passes (tofu fmt, linting)
  • Verify tofu plan shows expected repository creation

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added the public osac-metering-service repository.
    • Set up an e2e-test environment for the repository.
  • Security / Access
    • Configured team permissions, including push access for designated teams and admin access for infrastructure maintainers.
    • Applied repository push allowance settings to control write access.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 441b8994-968e-4fc7-ad4a-22a628ceffb2

📥 Commits

Reviewing files that changed from the base of the PR and between aee46d7 and 9572512.

📒 Files selected for processing (1)
  • repositories.tf

Walkthrough

Adds Terraform configuration for a public osac-metering-service repository, including team permissions, push allowances, and an e2e-test environment.

Changes

Repository configuration

Layer / File(s) Summary
Repository definition
repositories.tf
Adds the public repository module with team access, push allowances, nullable approval requirements, and the e2e-test environment.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: larsks, eliorerz, liatb-rh

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ai-Attribution ⚠️ Warning PR/commit mention Claude Code, but HEAD uses Co-Authored-By: Claude and has no Assisted-by or Generated-by trailer. Replace the AI Co-Authored-By trailer with the required Red Hat attribution trailer (Assisted-by or Generated-by) and keep human authorship separate.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding the osac-metering-service repository configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The only new block is a repo config with non-secret literals; no API keys, tokens, passwords, private keys, embedded creds, or long base64 strings were added.
No-Weak-Crypto ✅ Passed The only added content is a Terraform repo module; it contains no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
No-Injection-Vectors ✅ Passed PASS: The change is a static Terraform module block; no eval/shell/pickle/yaml/os.system/dangerouslySetInnerHTML or similar injection sinks were introduced.
Container-Privileges ✅ Passed Only repositories.tf changed; no container/K8s manifests or privilege-related fields (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation) were added.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds static repository metadata in Terraform; no logging statements or sensitive data exposure are introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ygalblum ygalblum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@larsks
larsks force-pushed the add-osac-metering-service branch from 58e188d to f6862df Compare July 14, 2026 15:32
Co-Authored-By: Moti Asayag <masayag@redhat.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
@larsks
larsks force-pushed the add-osac-metering-service branch from f6862df to 9572512 Compare July 14, 2026 17:05
@larsks
larsks enabled auto-merge (rebase) July 14, 2026 17:05
@larsks
larsks merged commit 1851e2d into osac-project:main Jul 14, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants