Revert "OSAC-3534: Set archived=true for repos merged into osac mono-repo"

[eliorerz]

Reverts #158

Summary by CodeRabbit

• Configuration
  • Updated repository handling so selected repositories remain read-only through branch locking while pending archival.
  • Added branch-locking settings for installer and bare-metal operator repositories.
  • Clarified comments describing the frozen state and Terraform reconciliation behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1297ccbb-1c4a-44f7-bd95-317c68f9cfcd

📥 Commits

Reviewing files that changed from the base of the PR and between 0ea3007 and ed71d44.

📒 Files selected for processing (1)

• repositories.tf

---

Walkthrough

The Terraform repository declarations replace archival settings with read-only or frozen-state comments. The installer and bare-metal operator now use Terraform-managed branch locking.

Changes

Repository state management

Layer / File(s)	Summary
Merged repository locking repositories.tf	fulfillment-service, osac-operator, osac-aap, and osac-csi-driver no longer set archived = true. Their declarations document the locked, read-only state pending archival.
Installer and operator locking repositories.tf	osac-installer and bare-metal-fulfillment-operator remove archival configuration, document their frozen pre-merge state, and enable lock_branch = true.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• osac-project/github-config#150: Extends Terraform-managed lock_branch configuration to additional merged repositories.
• osac-project/github-config#155: Adds the same repo_osac_installer lock_branch = true setting.
• osac-project/github-config#158: Replaces archival configuration with Terraform-managed branch locking for the same repositories.

Suggested reviewers: larsks, omer-vishlitzky

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states that the pull request reverts the archival change described in the objectives and changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets	✅ Passed	The commit changes only repositories.tf; added lines contain comments and lock_branch=true, with no secret literals, credential URLs, private-key material, or long base64 strings.
No-Weak-Crypto	✅ Passed	The PR changes only repositories.tf, replacing archived flags with lock_branch settings and comments; no weak crypto, custom crypto, or secret comparisons are present.
No-Injection-Vectors	✅ Passed	The PR only changes Terraform repository flags and comments; scans found no SQL concatenation, shell=True, eval/exec, pickle.loads, unsafe yaml.load, os.system, or dangerouslySetInnerHTML.
Container-Privileges	✅ Passed	The PR changes only Terraform GitHub repository settings. No privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings exist.
No-Sensitive-Data-In-Logs	✅ Passed	The PR changes only Terraform comments and lock_branch settings; the added lines contain no logging calls, secrets, tokens, credentials, or customer data.
Ai-Attribution	✅ Passed	The PR description and HEAD commit do not mention AI; the prior AI-assisted commit uses an Assisted-by trailer, and no Co-Authored-By AI trailer is present.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-158-feat/OSAC-3534-archive-merged-repos

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}