Skip to content

Revert "Require remaining osac CI checks in merge gate" - #206

Merged
omer-vishlitzky merged 1 commit into
mainfrom
revert-205-ci/osac-more-required-checks
Sep 2, 2026
Merged

Revert "Require remaining osac CI checks in merge gate"#206
omer-vishlitzky merged 1 commit into
mainfrom
revert-205-ci/osac-more-required-checks

Conversation

@omer-vishlitzky

@omer-vishlitzky omer-vishlitzky commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Reverts #205

Summary

  • CI: Reverts the remaining required status checks for the osac repository merge queue. The merge gate now requires only the remaining integration-test, pre-commit, and generated-code checks.
  • API surface, controllers, database, auth, deployment, tests, documentation: No changes.

Backward compatibility

This change affects merge-gate enforcement only. It does not change runtime behavior, APIs, deployed resources, or stored data. It reduces CI protection because 12 checks are no longer required for merging.

Risk classification

risk:ship — Configuration-only change with no runtime, API, deployment, database, or security impact. It is close to risk:show because it weakens required CI checks, but it does not alter application behavior or production systems.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 93f9e218-33db-4b52-996b-1e21b4e81397

📥 Commits

Reviewing files that changed from the base of the PR and between c327960 and d274cd7.

📒 Files selected for processing (1)
  • repositories.tf
💤 Files with no reviewable changes (1)
  • repositories.tf

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The repo_osac module now requires only the remaining integration-test, pre-commit, and generated-code checks for its merge queue.

Changes

OSAC merge queue configuration

Layer / File(s) Summary
Trim required status checks
repositories.tf
The repo_osac module removes 12 checks from required_status_checks. Integration-test, pre-commit, and generated-code checks remain required.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d274c

This localized change reverts the additional required CI checks, and no actionable merge-blocking risk remains based on the supplied evidence.

Suggested labels: risk:ask

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: reverting the requirement for the remaining osac CI checks in the merge gate. It matches the described changes and PR objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed PASS: The pull request changes only repositories.tf and contains 0 additions and 14 deletions. The deleted lines are status-check entries, not credentials. The changed file contains no credential-re…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only repositories.tf and deletes 14 CI status-check entries. It adds no cryptographic code or configuration, and the added-line scan found no MD5, SHA1, DES, RC4, Blow…
No-Injection-Vectors ✅ Passed PASS. The pull request changes only repositories.tf and removes 12 required status-check entries. It adds no code or input handling. The changed block contains no SQL concatenation, shell=True, `e…
Container-Privileges ✅ Passed PASS. The pull request changes only repositories.tf and removes GitHub status-check entries from repo_osac.required_status_checks. The diff introduces no container or Kubernetes manifest settings,…
No-Sensitive-Data-In-Logs ✅ Passed PASS — The pull request changes only repositories.tf and removes status-check entries from repo_osac.required_status_checks. The diff adds no code, logging, output, or sensitive-data handling. The…
Ai-Attribution ✅ Passed PASS: The PR description and the sole PR commit mention no AI tool. The commit has no Co-Authored-By, Assisted-by, or Generated-by trailer. The parent commit contains an old coderabbit.ai generated-…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: No-Hardcoded-Secrets

Explanation

PASS: The pull request changes only repositories.tf and contains 0 additions and 14 deletions. The deleted lines are status-check entries, not credentials. The changed file contains no credential-related identifiers, credential-bearing URLs, or long base64/hex literals.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes only repositories.tf and deletes 14 CI status-check entries. It adds no cryptographic code or configuration, and the added-line scan found no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison indicators.

Full details: No-Injection-Vectors

Explanation

PASS. The pull request changes only repositories.tf and removes 12 required status-check entries. It adds no code or input handling. The changed block contains no SQL concatenation, shell=True, eval/exec, pickle.loads, unsafe yaml.load, os.system, or dangerouslySetInnerHTML usage.

Full details: Container-Privileges

Explanation

PASS. The pull request changes only repositories.tf and removes GitHub status-check entries from repo_osac.required_status_checks. The diff introduces no container or Kubernetes manifest settings, and no changed or tracked configuration contains privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS — The pull request changes only repositories.tf and removes status-check entries from repo_osac.required_status_checks. The diff adds no code, logging, output, or sensitive-data handling. The module maps this list only to GitHub required status checks.

Full details: Ai-Attribution

Explanation

PASS: The PR description and the sole PR commit mention no AI tool. The commit has no Co-Authored-By, Assisted-by, or Generated-by trailer. The parent commit contains an old coderabbit.ai generated-comment marker, but that commit is outside this PR range and is only being reverted.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-205-ci/osac-more-required-checks

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the risk:ask label Sep 2, 2026
@omer-vishlitzky
omer-vishlitzky merged commit 4ea9db4 into main Sep 2, 2026
2 of 3 checks passed
minmzzhang added a commit that referenced this pull request Sep 3, 2026
## Summary
- Resubmit of #205 after #206 revert, now that
[osac-project/osac#717](osac-project/osac#717)
is merged
- Add remaining cheap osac CI jobs to `repo_osac` merge-queue required
checks
- Covers ansible-lint, FS python/go/binaries, helm CRD sync, installer
helm lint, darwin keychain, operator/BMF unit tests, metering
generated-code, dependency-review
- Step skip still reports success, so unrelated PRs are not blocked

osac#717 makes those workflows always report these names on
`pull_request`/`merge_group`. Applying this ruleset before that left the
merge queue waiting for checks that never started.

## Jira
N/A

## Test plan
- [x] osac#717 merged
- [ ] Context names match osac GitHub Actions job `name:` (or job id if
unnamed)
- [ ] Docs-only / unrelated-component PRs still merge (names report,
work skipped)

---

_This PR description was drafted with AI assistance
([create-pr](https://github.com/osac-project/osac-workspace/tree/main/skills/create-pr)
v0.1.3). Review for accuracy_

Signed-off-by: Min Zhang <minzhang@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant