refactor(just)!: move to directory with flat recipes - #39
Closed
retr0h wants to merge 1 commit into
Closed
Conversation
Convert the just module to the pattern established by md: its own
directory with its own README, consumed via `import?` with flat
prefixed recipes rather than `mod?` with `::` namespacing.
The `::` namespacing bought nothing here. Prefixed recipe names read
better at the call site (`just just-fmt-check`), and dropping the shim
removes the working-directory indirection that made modules awkward to
reason about.
BREAKING CHANGE: `just.just` moved to `just/just.just` and
`just.mod.just` is removed. Recipes `fmt` and `fmt-check` are now
`just-fmt` and `just-fmt-check`. Consumers must change
mod just '.just/remote/just.mod.just'
just just::fmt-check
to
import? '.just/remote/just.just'
just just-fmt-check
and update the fetch URL to main/just/just.just, dropping the
just.mod.just fetch entirely.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Thank you for contributing to this project! 😊🕹️ |
Contributor
Author
|
Superseded — redone against current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the
justmodule to the pattern established bymdin #37: its owndirectory with its own README, consumed via
import?with flat prefixedrecipes instead of
mod?with::namespacing.The
::namespacing bought nothing. Prefixed names read better at the callsite (
just just-fmt-check), and dropping the shim removes theworking-directory indirection — the same indirection that made
docs.mod.justunusable in repos without a
docs/directory.Breaking change
Consumers must change:
to:
and update the fetch URL to
main/just/just.just, dropping thejust.mod.justfetch entirely.Affected repos:
gohai,osapi,nats-client,nats-server— each usesmod justplusjust just::fmt-checkinjust-lint.yml. These will failtheir Just Lint job until ported.
In-repo updates
justfilenow usesimport 'just/just.just'and dogfoods the flat names.github/workflows/just-lint.ymlrunsjust just-fmt-checkdirectly,replacing
just --justfile just.just --working-directory . fmt-checkjustrow in the module table; the inline### just.justsection is removedCLAUDE.mdRepository Structure updatedTesting
just test(self-lint) passes — the repo formats its own justfiles throughthe converted module
just/just.justgives exit 1, restoring gives exit 0just/README.mdis stable undermd-fmt-checkFollow-up
Two modules now live in directories (
md,just);go,bats,docs,docker, andreactremain at the root inmod?style and are stilldocumented inline in the root README.
🤖 Generated with Claude Code