Fixed CreateEndToEndFlowsSwitch.processFlowStep()#2022
Merged
Conversation
output any error messages. Only if there are no connection instances that are valid, do we output an error. (I'm not sure this case is even possible, but that's another problem.)
was uncovered by tests for issue 879. Updated the unit tests for 879 and 1984.
lwrage
requested changes
Oct 16, 2019
Comment on lines
+619
to
+623
| // if (!result) { | ||
| // error(etei.getContainingComponentInstance(), "Cannot create end to end flow '" + etei.getName() | ||
| // + "' because the end of the semantic connection '" + conni.getComponentInstancePath() | ||
| // + "' does not connect to the start of flow '" + fimpl.getSpecification().getName() + "'"); | ||
| // } |
Comment on lines
+641
to
+647
| // if (!result) { | ||
| // error(etei.getContainingComponentInstance(), | ||
| // "Cannot create end to end flow '" + etei.getName() + "' because flow '" | ||
| // + fimpl.getSpecification().getName() | ||
| // + "' does not connect to the start of the semantic connection '" | ||
| // + conni.getComponentInstancePath() + "'"); | ||
| // } |
added 2 commits
October 17, 2019 10:25
…osate2.git into 1984_errors_on_path_not_taken
lwrage
approved these changes
Oct 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1984