cmd: add new describe-image command - #9
Conversation
998df9d to
1664311
Compare
|
Since #6 has landed for a while now we can probably undraft this. One thing, perhaps we can call it |
1664311 to
7625143
Compare
|
While looking at https://github.com/osbuild/bootc-image-builder/pull/808 I was wondering if we could make it easier to figure out what packages are part of an image and then I did remember this PR. I think the output needs work and it ideally would be an input to osbuild/image-builder#1104 but we are not there yet. So I was thinking in the meantime we simply could have a warning and mark it as an unstable feature (and deliberately break the yaml from being parseable) and then it would be a useful debug tool already. Wdyt? |
7625143 to
89d7a1e
Compare
|
@mvo5 I randomly picked one failed RPM build in COPR, and it seems to be failing on unit tests, which is strange because they passed in the GH Action. Could you please take a look? |
thozza
left a comment
thozza
left a comment
There was a problem hiding this comment.
LGTM, but unit tests are failing in RPM builds in COPR, so blocking the PR, because those are probably not required.
This commit adds a new `describe-image` comamnd that contains the details about the given image type. The output is yaml as it is both nicely human readable and also machine readable. Note that this version carries an invalid yaml header on purpose to avoid people replying on the feature for scripts before it is stable. The output looks like this: ```yaml $ ./image-builder describe-image rhel-9.1 tar @warning - the output format is not stable yet and may change distro: rhel-9.1 type: tar arch: x86_64 os_vesion: "9.1" bootmode: none partition_type: "" default_filename: root.tar.xz packages: include: - policycoreutils - selinux-policy-targeted - selinux-policy-targeted exclude: - rng-tools ``` Thanks to Ondrej Budai for the idea and the example.
89d7a1e to
56a9a01
Compare
|
@thozza you have requested changes still :) |
|
@supakeen its actually @achilleas-k how still has a "change-request" open (the GH ui is a bit confusing) |
|
Sorry! |
4 participants
[While this should follow https://github.com/osbuild/image-builder/pull/1104, i.e. this output should be used as input in https://github.com/osbuild/image-builder/pull/1104 we could still make it available as an unstable feature?]
This commit adds a new
describe-imagecomamnd that containsthe details about the given image type. The output is yaml as
it is both nicely human readable and also machine readable.
The output looks like this:
Thanks to Ondrej Budai for the idea and the example.