fix: incomplete toolbar back button customization#1991
Merged
WhiredPlanck merged 1 commit intoosfans:developfrom Apr 18, 2026
Merged
fix: incomplete toolbar back button customization#1991WhiredPlanck merged 1 commit intoosfans:developfrom
WhiredPlanck merged 1 commit intoosfans:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to make the toolbar/tab-bar “back” button styling follow theme customization more consistently by centralizing back-button rendering in shared UI components instead of per-window implementations.
Changes:
- Removes the clipboard window’s custom back button and relies on the shared tab bar back button instead.
- Updates
TabUito build its back button using theme toolbar configuration (viabackStyle) when possible. - Tightens
ToolButtonstyle handling (non-nullstyle, simplified style-update checks) and adjusts toolbar button click callback types.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/java/com/osfans/trime/ime/clipboard/ClipboardWindow.kt | Removes clipboard-specific back wiring and lets the shared tab bar handle navigation. |
| app/src/main/java/com/osfans/trime/ime/clipboard/ClipboardTitleUi.kt | Removes the embedded back button from the clipboard title layout. |
| app/src/main/java/com/osfans/trime/ime/bar/ui/ToolButton.kt | Makes style handling stricter (non-null) and simplifies style-update detection. |
| app/src/main/java/com/osfans/trime/ime/bar/ui/TabUi.kt | Adds themed back-button construction intended to respect tool_bar.back_style. |
| app/src/main/java/com/osfans/trime/ime/bar/ui/ButtonsBarUi.kt | Changes the click callback type and refactors click/long-click setup. |
| app/src/main/java/com/osfans/trime/ime/bar/ui/AlwaysUi.kt | Changes click callback type and refactors button creation; currently introduces a state-switch crash risk. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d2406d6 to
b0d9304
Compare
Bambooin
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes # N/A
Feature
Describe features of this pull request
Code of conduct
Code style
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info