Skip to content

fix: incomplete toolbar back button customization#1991

Merged
WhiredPlanck merged 1 commit intoosfans:developfrom
WhiredPlanck:fix-incomplete-back-style
Apr 18, 2026
Merged

fix: incomplete toolbar back button customization#1991
WhiredPlanck merged 1 commit intoosfans:developfrom
WhiredPlanck:fix-incomplete-back-style

Conversation

@WhiredPlanck
Copy link
Copy Markdown
Collaborator

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes # N/A

Feature

Describe features of this pull request

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make the toolbar/tab-bar “back” button styling follow theme customization more consistently by centralizing back-button rendering in shared UI components instead of per-window implementations.

Changes:

  • Removes the clipboard window’s custom back button and relies on the shared tab bar back button instead.
  • Updates TabUi to build its back button using theme toolbar configuration (via backStyle) when possible.
  • Tightens ToolButton style handling (non-null style, simplified style-update checks) and adjusts toolbar button click callback types.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
app/src/main/java/com/osfans/trime/ime/clipboard/ClipboardWindow.kt Removes clipboard-specific back wiring and lets the shared tab bar handle navigation.
app/src/main/java/com/osfans/trime/ime/clipboard/ClipboardTitleUi.kt Removes the embedded back button from the clipboard title layout.
app/src/main/java/com/osfans/trime/ime/bar/ui/ToolButton.kt Makes style handling stricter (non-null) and simplifies style-update detection.
app/src/main/java/com/osfans/trime/ime/bar/ui/TabUi.kt Adds themed back-button construction intended to respect tool_bar.back_style.
app/src/main/java/com/osfans/trime/ime/bar/ui/ButtonsBarUi.kt Changes the click callback type and refactors click/long-click setup.
app/src/main/java/com/osfans/trime/ime/bar/ui/AlwaysUi.kt Changes click callback type and refactors button creation; currently introduces a state-switch crash risk.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/src/main/java/com/osfans/trime/ime/bar/ui/AlwaysUi.kt Outdated
Comment thread app/src/main/java/com/osfans/trime/ime/bar/ui/AlwaysUi.kt
Comment thread app/src/main/java/com/osfans/trime/ime/bar/ui/TabUi.kt Outdated
@WhiredPlanck WhiredPlanck force-pushed the fix-incomplete-back-style branch from d2406d6 to b0d9304 Compare April 17, 2026 12:26
@WhiredPlanck WhiredPlanck requested a review from Bambooin April 17, 2026 12:44
@WhiredPlanck WhiredPlanck merged commit 91b91ac into osfans:develop Apr 18, 2026
4 checks passed
@WhiredPlanck WhiredPlanck deleted the fix-incomplete-back-style branch April 18, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants