Henshaw precession - #48
Merged
Merged
Conversation
Modified to included both the original precession parameter chi_p and the updated averaged precession paramter chi_pavg. These are both implemented to make use of the multiprocessing package. Requires use of the updated version of lalsimutils.
Modified version of lalsimutils that includes an extract_param option for chi_pavg, the updated averaged precession parameter. This requires use of the python package "precession" which must be added to your virtual environment.
changed to include try/except to print a warning if precession module not found.
oshaughn
pushed a commit
that referenced
this pull request
Aug 7, 2026
…_diagnostic Off-path warm-start support-mismatch diagnostic (escaped_mass) + its ROC assessment
oshaughn
pushed a commit
that referenced
this pull request
Aug 7, 2026
Conflict was structural, not semantic: both sides added a method immediately before bootstrap_from_samples, and the two bootstrap signatures differed. Resolution keeps BOTH bodies -- the merged diagnostic and reset_adaptation -- with the single signature that carries keep_backstop_cold. Verified after resolution: 22 portfolio tests and all 5 of the diagnostic's own tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated versions of plot_posterior_corner and lalsimutils. Use of this parameter calculation requires installation of the "precession" module in your local virtual environment. Please let me know if you have any issues.