Merge wf fd - #77
Merged
Merged
Conversation
…fication of needed requirements like HAS_CVMFS_software_igwn_org
…ontrol over waveform version options as here https://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/371; note a proliferation of such options
…ument to allow flexible fd_centering_factor (don't always put merger in center - pessimistic/poor interaction with tapering)
…eeds to also shift accordingly)
…m lalsim.SimIMRPhenomXPCalculateModelParametersFromSourceFrame, and also compensate for polarization. Modify rotate_hlm_static to take an extra overall polarization factor. Update docs for extract_JL_angles to be clearer
* OrbitalAngularMomentumAtReference : updated expression to higher order * extract_JL_angles : update expressions derived from J,L to be accurate, avoid confusing return values from lalsuite routines * fd_L_frame use case: perform rotation with convention that makes sense, validated against high-q binaries radiation (waveform orientation XPHM vs SEOBNRv4PHM)
…time (idea that ILE will default to 2s), so we don't inadvertently truncate signals at T/2. Time control rather than fractional control previously provided by fd_centering_factor
…oseFDModes branch, to minimize inadvertent trimming of long waveforms
…ernal_waveform_fd_L_frame
Owner
Author
|
Also updates waveform angle code
|
Owner
Author
|
DCC document on frame issues: https://dcc.ligo.org/LIGO-T2300304 |
Owner
Author
|
Head to head tests with semi-random binaries comparing rotated L frame dominant modes to IMRPv2-style-workaround-generated hlm(t) have great agreement. Merging. |
oshaughn
pushed a commit
that referenced
this pull request
Aug 13, 2026
…m-fix calmarg fused self-term fix: per-realization rho_sq_c = <C_c h|C_c h>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChooseFDModes logic branch: Better handling of conditioning, to avoid inadvertently trimming waveform to length T/2 when active.
Auto-align event time in FD waveform from ChooseFD to be 2s before end of segment by default (with ILE)
5805bcd
04a45a5
21adf9a
63efc76
8e42441
79fd144
74dbc51
0e2cea7
5c0d1e2
e9d03c4