Conversation
osfrickler
reviewed
Mar 2, 2022
Starting with Xena, the loadbalancer group is required. To be downward compatible for the time being, OSISM continues to use haproxy internally for the moment. The haproxy group is deprecated as of now and will be removed in the future. Signed-off-by: Christian Berendt <berendt@osism.tech>
berendt
force-pushed
the
add-loadbalancer-group
branch
from
0d99498 to
1500a4b
Compare
osfrickler
approved these changes
Mar 2, 2022
Member
osfrickler
left a comment
osfrickler
left a comment
There was a problem hiding this comment.
After looking at what I did in my testing patch, we might even want to reverse the dependencies, like set:
[keepalived:children]
loadbalancer
[haproxy:children]
loadbalancer
But that's fine for a followup patch I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with Xena, the loadbalancer group is required.
To be downward compatible for the time being, OSISM
continues to use haproxy internally for the moment.
The haproxy group is deprecated as of now and will be
removed in the future.
Signed-off-by: Christian Berendt berendt@osism.tech