Conversation
scoopex
force-pushed
the
improve-makefile
branch
from
5950bfe to
cf315ee
Compare
berendt
left a comment
berendt
left a comment
There was a problem hiding this comment.
Not sure where is the benefit of venv over .venv. We also have .tox and not tox. I don't have a strong opinion on this. Should just be changed everywhere then. In the cloud-in-a-box it's .venv at the moment. In the testbed it's venv after your Makefile changes there.
leaving old .venv to avoid accidental additions |
osfrickler
left a comment
osfrickler
left a comment
There was a problem hiding this comment.
I don't think it is good to change from .venv to venv just for a single repo, this should be consistent across all osism repos
scoopex
force-pushed
the
improve-makefile
branch
from
d9064cb to
f055861
Compare
* add prompt * no not use a hidden venv dir Signed-off-by: Marc Schöchlin <schoechlin@osb-alliance.com>
Signed-off-by: Marc Schöchlin <schoechlin@osb-alliance.com>
- leaving old .venv to avoid accidental additions Signed-off-by: Marc Schöchlin <schoechlin@osb-alliance.com>
Signed-off-by: Marc Schöchlin <schoechlin@osb-alliance.com>
Signed-off-by: Christian Berendt <berendt@osism.tech>
3 participants
No description provided.