Conversation
The goal is to automatically clean nodes on undeployment. This can be done by ironic through automated cleaning. Unfortunately this will also enable cleaning when a node transitions from `managable` to `available`. This would block `osism sync ironic`, since it waits sequentially for every node to reach the `available` state. An alternative is to add an explicit clean step in python-osism. However the `osism manage baremetal undeploy` command is currently a oneshot request to ironic. Adding a cleaning step would require turning it inot an asynchronous task. The taken path is to enable automated cleaning explicitly on a per node basis once it reaches the `available` state. Care has to be taken to unset it before transitioning to `available`, since ironic sometimes moves nodes to `manageable` when errors are encountered. Depends-On: osism/metalbox#292 Signed-off-by: Jan Horstmann <horstmann@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to automatically clean nodes on undeployment. This can be done by ironic through automated cleaning. Unfortunately this will also enable cleaning when a node transitions from
managabletoavailable. This would blockosism sync ironic, since it waits sequentially for every node to reach theavailablestate.An alternative is to add an explicit clean step in python-osism. However the
osism manage baremetal undeploycommand is currently a oneshot request to ironic. Adding a cleaning step would require turning it inot an asynchronous task.The taken path is to enable automated cleaning explicitly on a per node basis once it reaches the
availablestate. Care has to be taken to unset it before transitioning toavailable, since ironic sometimes moves nodes tomanageablewhen errors are encountered.Depends-On: osism/metalbox#292