Add --afi filter option to report bgp command

[berendt]

AI-assisted: Claude Code

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• In the BGP AFI filtering loop, you recompute [a.lower() for a in parsed_args.afi] for every AFI; consider precomputing a lowercased set/list of AFIs once before the loop to avoid repeated work and make the intent clearer.
• For the new --afi argument, you may want to leverage choices (or a small validator) in argparse to restrict values to known address families and catch invalid input early instead of silently filtering everything out.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In the BGP AFI filtering loop, you recompute `[a.lower() for a in parsed_args.afi]` for every AFI; consider precomputing a lowercased set/list of AFIs once before the loop to avoid repeated work and make the intent clearer.
- For the new `--afi` argument, you may want to leverage `choices` (or a small validator) in argparse to restrict values to known address families and catch invalid input early instead of silently filtering everything out.

## Individual Comments

### Comment 1
<location path="osism/commands/report.py" line_range="402-407" />
<code_context>
                 bgp_data = json.loads(bgp_result.stdout)

                 for afi, afi_data in bgp_data.items():
+                    if parsed_args.afi and afi.lower() not in [a.lower() for a in parsed_args.afi]:
+                        continue
                     peers = afi_data.get("peers", {})
</code_context>
<issue_to_address>
**suggestion:** Avoid recomputing the lowercased AFI list on every loop iteration by normalizing once up front.

This recreates a lowercased AFI list on every iteration of `bgp_data.items()`. To avoid repeated work and clarify intent, normalize the filter once before the loop, e.g.

```python
afi_filter = None
if parsed_args.afi:
    afi_filter = {a.lower() for a in parsed_args.afi}

for afi, afi_data in bgp_data.items():
    if afi_filter is not None and afi.lower() not in afi_filter:
        continue
    ...
```

This keeps normalization centralized and the loop leaner.

```suggestion
                bgp_data = json.loads(bgp_result.stdout)

                afi_filter = None
                if parsed_args.afi:
                    afi_filter = {a.lower() for a in parsed_args.afi}

                for afi, afi_data in bgp_data.items():
                    if afi_filter is not None and afi.lower() not in afi_filter:
                        continue
                    peers = afi_data.get("peers", {})
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}