Conversation
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="tests/unit/test_smoke.py" line_range="10-11" />
<code_context>
+ assert osism is not None
+
+
+def test_package_has_version_attribute():
+ assert hasattr(osism, "__version__")
</code_context>
<issue_to_address>
**suggestion (testing):** Extend the version smoke test to validate the value of `__version__`, not only its presence.
`hasattr(osism, "__version__")` would still pass if `__version__` were `None` or an unexpected type. To make the test more robust, also assert that it is a non-empty string, for example:
```python
assert isinstance(osism.__version__, str)
assert osism.__version__
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
20dca73 to
0c244da
Compare
This was referenced Apr 24, 2026
ideaship
requested changes
Apr 24, 2026
Contributor
ideaship
left a comment
There was a problem hiding this comment.
According to setup.cfg, this repo supports python>=3.8, but with this change, that is no longer true. You'd have to lift it to 3.10. The only current OS that ships an older python (that I know of) is macOS which ships 3.9.6.
Member
Author
That's fine. We use Python >= 3.10 in all container images where we want to use it. For local tests I think that's also fine. At least it's pretty simple to use Python >= 3.10 on MacOS. |
Set up the minimal infrastructure so unit tests can be added in follow-up issues. Covers #2192. - Add [dev-packages] in Pipfile: pytest, pytest-cov, pytest-mock - Create tests/ layout with a smoke test asserting osism is importable and exposes __version__ - Configure pytest via [tool:pytest] in setup.cfg - Raise minimum Python to 3.10 (python_requires and classifiers in setup.cfg) so tests and code can rely on modern language features - Add playbooks/test-unit.yml and a new python-osism-unit-tests Zuul job wired into the check and periodic-daily pipelines; the existing python-osism-test-setup job is kept in parallel (replace decision left to review per the issue) - Document local test execution in README.md Closes #2192 AI-assisted: Claude Code Signed-off-by: Christian Berendt <berendt@osism.tech>
ideaship
approved these changes
Apr 24, 2026
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up the minimal infrastructure so unit tests can be added in follow-up issues. Covers #2192.
Closes #2192
AI-assisted: Claude Code