Add unit tests for osism/tasks/conductor/sonic/interface detection

[berendt]

Cover detect_breakout_ports and detect_port_channels in osism/tasks/conductor/sonic/interface.py with 49 test cases: early-exit paths, NetBox-format breakout for all supported speeds, SONiC-format 400G and standard breakout, and the LAG-name regex variants (named, numeric fallback, case-insensitive, unnamed).

Closes #2220

AI-assisted: Claude Code

[sourcery-ai]

Hey - I've left some high level feedback:

• The test module is quite large and covers two distinct behaviours (detect_breakout_ports and detect_port_channels); consider splitting it into separate files (e.g. test_breakout_detection.py and test_port_channel_detection.py) to keep each test suite focused and easier to navigate.
• Several tests construct similar port_config dictionaries inline; you could factor the common port_config shapes into small helper functions or fixtures (similar to _port_config_for_port) to reduce duplication and make intent clearer when reading each test.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The test module is quite large and covers two distinct behaviours (`detect_breakout_ports` and `detect_port_channels`); consider splitting it into separate files (e.g. `test_breakout_detection.py` and `test_port_channel_detection.py`) to keep each test suite focused and easier to navigate.
- Several tests construct similar `port_config` dictionaries inline; you could factor the common port_config shapes into small helper functions or fixtures (similar to `_port_config_for_port`) to reduce duplication and make intent clearer when reading each test.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}