Add unit tests for osism/utils connection initialization helpers

[berendt]

Cover _init_redis, _init_nb, _init_secondary_nb_list, _get_timeout_http_adapter_class, NetBoxSessionManager, cleanup_netbox_sessions, get_netbox_connection,
get_openstack_connection and the lazy getattr indirection in osism/utils/init.py.

Closes #2228

AI-assisted: Claude Code

[sourcery-ai]

Hey - I've left some high level feedback:

• The reset_module_globals fixture duplicates the same reset logic before and after yield; consider extracting this into a small helper function or loop to avoid repetition and make future updates less error-prone.
• Many of the _init_secondary_nb_list tests share similar setup and assertion patterns; you could use pytest.mark.parametrize to consolidate these into fewer parametrized tests and improve readability and maintainability.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The `reset_module_globals` fixture duplicates the same reset logic before and after `yield`; consider extracting this into a small helper function or loop to avoid repetition and make future updates less error-prone.
- Many of the `_init_secondary_nb_list` tests share similar setup and assertion patterns; you could use `pytest.mark.parametrize` to consolidate these into fewer parametrized tests and improve readability and maintainability.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ideaship]

The empty_url, missing_token, and whitespace_token cases all pass
log_substring=None. But the production code reaches the except
(yaml.YAMLError, TypeError, ValueError) branch for all three and logs "Error
parsing settings NETBOX_SECONDARIES: ...". The tests only verify result == [],
leaving the error-logging path unverified — yet the six other error cases in
the same parametrize do check logs. Inconsistency means a future deletion of
the logger.error(...) call would not be caught by these three cases.